From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] eal: deprecate rte_cpu_check_supported
Date: Tue, 04 Apr 2017 16:01:30 +0200
Message-ID: <1610139.QdKl0Sncku@xps13>
References: <20170331183122.22961-1-aconole@redhat.com>
 <2833575.ok4SoAkeVM@xps13> <f7td1cs70ly.fsf@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Aaron Conole <aconole@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id 48A42293B
 for <dev@dpdk.org>; Tue,  4 Apr 2017 16:01:32 +0200 (CEST)
Received: by mail-wm0-f47.google.com with SMTP id x124so28837630wmf.0
 for <dev@dpdk.org>; Tue, 04 Apr 2017 07:01:32 -0700 (PDT)
In-Reply-To: <f7td1cs70ly.fsf@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-04-04 09:39, Aaron Conole:
> Hi Thomas,
> 
> Thomas Monjalon <thomas.monjalon@6wind.com> writes:
> 
> > 2017-03-31 14:31, Aaron Conole:
> >> It's likely that this function isn't used anywhere, but since it was part of
> >> the public API, mark the function for deprecation for at least one release.
> >> 
> >> Signed-off-by: Aaron Conole <aconole@redhat.com>
> 
> Thanks so much for the review!  I'll make sure to fix these with v2.
> 
> > [...]
> >> +DPDK_17.05 {
> >> +	global;
> >> +
> >> +	rte_cpu_is_supported;
> >> +
> >> +} DPDK_17.02;
> >
> > Should not it be a separate patch?
> 
> I thought it made sense to keep it rolled in with this patch, but if you
> prefer it separate, I will do that.  Expect it as 1/2 in v2, unless you
> say otherwise.

Yes 2 patches in v2. Thanks