From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-stable] [PATCH v14 6/6] devtools: expand meson
	cross compiling test coverage
Date: Wed, 11 Jul 2018 19:46:00 +0200
Message-ID: <1611182.N2xzx1MTAb@xps>
References: <20180625024913.17219-1-gavin.hu@arm.com>
 <20180629172738.2121-1-gavin.hu@arm.com>
 <20180629172738.2121-7-gavin.hu@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, nd@arm.com
To: Gavin Hu <gavin.hu@arm.com>
Return-path: <dev-bounces@dpdk.org>
Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com
 [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id BA2061B4C0
 for <dev@dpdk.org>; Wed, 11 Jul 2018 19:46:04 +0200 (CEST)
In-Reply-To: <20180629172738.2121-7-gavin.hu@arm.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

29/06/2018 19:27, Gavin Hu:
> The default test script covers only default host cc compiler, either gcc or
> clang, the fix is to increase the coverage by adding one more to cover
> clang and the others for gcc.
> 
> Fixes: a55277a788 ("devtools: add test script for meson builds")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Song Zhu <song.zhu@arm.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  devtools/test-meson-builds.sh | 22 ++++++++++++++--------
>  1 file changed, 14 insertions(+), 8 deletions(-)
> 
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
> index 9bb5b93bd..f38304e6e 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -15,7 +15,7 @@ if command -v ninja >/dev/null 2>&1 ; then
>  elif command -v ninja-build >/dev/null 2>&1 ; then
>      ninja_cmd=ninja-build
>  else
> -    echo "## ERROR: ninja is missing, please install..."
> +    echo "ERROR: ninja is not found"

This is changing a (not related) line introduced in patch 4.
I will squash myself if no other error is found.