From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] vhost: fetch again ring_addrs address after
	NUMA reallocation
Date: Fri, 13 Oct 2017 21:31:44 +0200
Message-ID: <1611613.caVE2u6YoK@xps>
References: <20171013093021.3196-1-maxime.coquelin@redhat.com>
 <20171013094347.oq7nwfnbm3yj7zkt@dhcp-192-218.str.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Jens Freimann <jfreimann@redhat.com>, yliu@fridaylinux.org,
 lei.a.yao@intel.com
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 340A61B781
 for <dev@dpdk.org>; Fri, 13 Oct 2017 21:31:46 +0200 (CEST)
In-Reply-To: <20171013094347.oq7nwfnbm3yj7zkt@dhcp-192-218.str.redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

13/10/2017 11:43, Jens Freimann:
> On Fri, Oct 13, 2017 at 09:30:21AM +0000, Maxime Coquelin wrote:
> >In case of NUMA reallocation, the virtqueue struct is reallocated
> >on another socket, meaning that its address changes.
> >
> >In translate_ring_addresses(), addr pointer was not fetched again
> >after the reallocation, so it pointed to freed memory.
> >
> >This patch just fetch again addr pointer after the reallocation.
> >
> >Reported-by: Yao, Lei A <lei.a.yao@intel.com>
> >Tested-by: Yao, Lei A <lei.a.yao@intel.com>
> >Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Reviewed-by: Jens Freimann <jfreimann@redhat.com>

Applied, thanks