From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] cmdline: standardize conversion of IP address strings Date: Mon, 23 Apr 2018 02:38:31 +0200 Message-ID: <1612207.9CW8VGUfN3@xps> References: <20180129102903.21203-1-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Olivier Matz To: dev@dpdk.org Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 1EC90F90 for ; Mon, 23 Apr 2018 02:38:35 +0200 (CEST) In-Reply-To: <20180129102903.21203-1-olivier.matz@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There was no review or ack for this patch. It will be merged soon if no comment. 29/01/2018 11:29, Olivier Matz: > The code to convert IPv4 and IPv6 address strings into a binary format > (inet_ntop) was included in the cmdline library because the DPDK was > historically compiled in environments where the standard inet_ntop() > function is not available. Today, this is not the case and the standard > inet_ntop() can be used. > > This patch removes the internal inet_ntop*() functions and their > specific license. > > There is a small functional impact: IP addresses like 012.34.56.78 > are not valid anymore. > > Signed-off-by: Olivier Matz