From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Matthew Hall <mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH 3/4] examples/*: -Wno-switch required for weird ioctl() ID's
Date: Mon, 21 Jul 2014 15:45:47 +0200 [thread overview]
Message-ID: <1612877.4vnACNrlm4@xps13> (raw)
In-Reply-To: <1405914461-19335-4-git-send-email-mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-07-20 20:47, Matthew Hall:
> +CFLAGS += -Wno-switch
As I said for patch 1/4,
I think it's better to fix the code instead of removing a warning.
If there is a very good reason to not do it, it would appear in the log.
Thanks
--
Thomas
next prev parent reply other threads:[~2014-07-21 13:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 3:47 [PATCH] examples: fix clang compilation issues Matthew Hall
[not found] ` <1405914461-19335-1-git-send-email-mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-07-21 3:47 ` [PATCH 1/4] l3fwd: some functions are unused in l3fwd-acl Matthew Hall
[not found] ` <1405914461-19335-2-git-send-email-mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-07-21 13:44 ` Thomas Monjalon
2014-07-21 16:53 ` Matthew Hall
2014-07-21 17:37 ` Richardson, Bruce
2014-07-21 3:47 ` [PATCH 2/4] virtio-net.c: incorrect parens around equality check Matthew Hall
[not found] ` <1405914461-19335-3-git-send-email-mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-07-22 13:14 ` Thomas Monjalon
2014-07-22 19:27 ` Matthew Hall
2014-07-21 3:47 ` [PATCH 3/4] examples/*: -Wno-switch required for weird ioctl() ID's Matthew Hall
[not found] ` <1405914461-19335-4-git-send-email-mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-07-21 13:45 ` Thomas Monjalon [this message]
2014-07-21 3:47 ` [PATCH 4/4] rte.extvars.mk: allow user to override RTE_SDK_BIN Matthew Hall
[not found] ` <1405914461-19335-5-git-send-email-mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-07-21 14:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1612877.4vnACNrlm4@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).