From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] mempool: rename functions with confusing names Date: Thu, 30 Jun 2016 22:05:55 +0200 Message-ID: <1613474.aBI9rN0qDz@xps13> References: <1467208504-13029-1-git-send-email-bruce.richardson@intel.com> <1467290965-3797-1-git-send-email-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, olivier.matz@6wind.com, keith.wiles@intel.com, Panu Matilainen To: Bruce Richardson Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 0FECA37B2 for ; Thu, 30 Jun 2016 22:05:59 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id v199so972022wmv.0 for ; Thu, 30 Jun 2016 13:05:59 -0700 (PDT) In-Reply-To: <1467290965-3797-1-git-send-email-bruce.richardson@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-06-30 13:49, Bruce Richardson: > The mempool_count and mempool_free_count behaved contrary to what their > names suggested. The free_count function actually returned the number of > elements that were allocated from the pool, not the number unallocated as > the name implied. > > Fix this by introducing two new functions to replace the old ones, > * rte_mempool_avail_count to replace rte_mempool_count > * rte_mempool_in_use_count to replace rte_mempool_free_count > > In this patch, the new functions are added, and the old ones are marked > as deprecated. All apps and examples that use the old functions are > updated to use the new functions. The ThunderX driver uses rte_mempool_count and needs an update. Except that, it looks good.