dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Qiu, Michael" <michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v6] VFIO: Avoid to enable vfio while the module not loaded
Date: Thu, 15 Jan 2015 14:38:27 +0100	[thread overview]
Message-ID: <1613897.2bqBHJQoa5@xps13> (raw)
In-Reply-To: <C6ECDF3AB251BE4894318F4E4512369780C24883-kPTMFJFq+rHjxeytcECX8bfspsVTdybXVpNB7YpNyf8@public.gmane.org>

> > When vfio module is not loaded when kernel support vfio feature, the
> > routine still try to open the container to get file description.
> > 
> > This action is not safe, and of cause got error messages:
> > 
> > EAL: Detected 40 lcore(s)
> > EAL:   unsupported IOMMU type!
> > EAL: VFIO support could not be initialized
> > EAL: Setting up memory...
> > 
> > This may make user confuse, this patch make it reasonable and much more
> > soomth to user.
> > 
> > Signed-off-by: Michael Qiu <michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> Acked-by: Anatoly Burakov <anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Note that rte_eal_check_module has no bsd counterpart.
It could be needed later.

Applied

Thanks
-- 
Thomas

  parent reply	other threads:[~2015-01-15 13:38 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04  3:36 [PATCH] VFIO: Avoid to enable vfio while the module not loaded Michael Qiu
     [not found] ` <1417664219-19679-1-git-send-email-michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-04 10:00   ` [PATCH v2] " Michael Qiu
     [not found]     ` <1417687227-21854-1-git-send-email-michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-05 10:00       ` Burakov, Anatoly
2014-12-08  7:25         ` Qiu, Michael
     [not found]           ` <533710CFB86FA344BFBF2D6802E60286C9D920-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-08 18:47             ` Burakov, Anatoly
2014-12-09  2:47               ` Qiu, Michael
     [not found]                 ` <533710CFB86FA344BFBF2D6802E60286C9DE19-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-09  9:51                   ` Burakov, Anatoly
2014-12-08  8:27       ` [PATCH v3] " Michael Qiu
     [not found]         ` <1418027255-7727-1-git-send-email-michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-08  9:54           ` Burakov, Anatoly
2014-12-08 10:28             ` Qiu, Michael
2014-12-08 10:44       ` [PATCH v4] " Michael Qiu
     [not found]         ` <1418035455-9434-1-git-send-email-michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-08 12:19           ` Burakov, Anatoly
2014-12-08 15:28             ` Qiu, Michael
     [not found]               ` <533710CFB86FA344BFBF2D6802E60286C9DB9E-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-10  0:17                 ` Xie, Huawei
2014-12-10  2:06                   ` Qiu, Michael
2014-12-10  2:22           ` [PATCH v5] " Michael Qiu
     [not found]             ` <1418178156-4153-1-git-send-email-michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-10  9:21               ` Burakov, Anatoly
2014-12-10 11:29                 ` Qiu, Michael
2014-12-10 11:46           ` [PATCH v6] " Michael Qiu
     [not found]             ` <1418211977-8218-1-git-send-email-michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-10 11:48               ` Burakov, Anatoly
2014-12-19  7:09                 ` Qiu, Michael
     [not found]                   ` <533710CFB86FA344BFBF2D6802E60286CA1227-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-19  8:23                     ` Thomas Monjalon
2014-12-22  1:21                       ` Qiu, Michael
     [not found]                 ` <C6ECDF3AB251BE4894318F4E4512369780C24883-kPTMFJFq+rHjxeytcECX8bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-15 13:38                   ` Thomas Monjalon [this message]
2015-01-15 13:42                     ` Burakov, Anatoly
     [not found]                       ` <C6ECDF3AB251BE4894318F4E4512369780C3CDC1-kPTMFJFq+rHjxeytcECX8bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-15 13:51                         ` Thomas Monjalon
2014-12-04 13:12   ` [PATCH] " Burakov, Anatoly
2014-12-04 13:47     ` Qiu, Michael
     [not found]       ` <533710CFB86FA344BFBF2D6802E60286C9CCC1-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-04 16:31         ` Burakov, Anatoly
2014-12-05  4:01           ` Qiu, Michael
2014-12-04 13:13   ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1613897.2bqBHJQoa5@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).