From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6] VFIO: Avoid to enable vfio while the module not loaded Date: Thu, 15 Jan 2015 14:38:27 +0100 Message-ID: <1613897.2bqBHJQoa5@xps13> References: <1418035455-9434-1-git-send-email-michael.qiu@intel.com> <1418211977-8218-1-git-send-email-michael.qiu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Qiu, Michael" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > > When vfio module is not loaded when kernel support vfio feature, the > > routine still try to open the container to get file description. > > > > This action is not safe, and of cause got error messages: > > > > EAL: Detected 40 lcore(s) > > EAL: unsupported IOMMU type! > > EAL: VFIO support could not be initialized > > EAL: Setting up memory... > > > > This may make user confuse, this patch make it reasonable and much more > > soomth to user. > > > > Signed-off-by: Michael Qiu > > Acked-by: Anatoly Burakov Note that rte_eal_check_module has no bsd counterpart. It could be needed later. Applied Thanks -- Thomas