From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6] checkpatches.sh: Add checks for ABI symbol addition Date: Mon, 28 May 2018 00:01:15 +0200 Message-ID: <1614896.1p8jHt5N2x@xps> References: <20180115190545.25687-1-nhorman@tuxdriver.com> <1725451.L7JxISGBU9@xps> <20180527210039.GA22397@neilslaptop.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, john.mcnamara@intel.com, bruce.richardson@intel.com, Ferruh Yigit , Stephen Hemminger To: Neil Horman Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1963F160 for ; Mon, 28 May 2018 00:01:18 +0200 (CEST) In-Reply-To: <20180527210039.GA22397@neilslaptop.think-freely.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/05/2018 23:00, Neil Horman: > On Sun, May 27, 2018 at 09:34:13PM +0200, Thomas Monjalon wrote: > > Hi Neil, > > > > Sorry, this patch has been forgotten during the whole release cycle. > > > Its ok, though that is frustrating, as we now need to re-familiarize ourselves > with how this patch works. I understand and apologize. > > I see an issue about the dependency on filterdiff. > > Is there a way to avoid it? > > > I suppose, but to do so would require some awk magic. Is there any advantage to > having an awk dependency rather than a filterdiff dependency? filterdiff is a > pretty universal tool. filterdiff is not installed on my machine. I guess it is the same for a lot of people. I will check how we can replace it. [...] > Fine, at this point, I don't know when I'll get to this though, its pretty busy > here at the moment. This delay is my fault, and I want to help. If I find a good solution, do you accept I send a version 7 of this patch?