From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH RFC 00/13] Update build system Date: Mon, 12 Jan 2015 17:51:59 +0100 Message-ID: <16150803.N0UIx0csq3@xps13> References: <1421080446-19249-1-git-send-email-sergio.gonzalez.monroy@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Sergio Gonzalez Monroy Return-path: In-Reply-To: <1421080446-19249-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Sergio, 2015-01-12 16:33, Sergio Gonzalez Monroy: > This patch series updates the DPDK build system. Thanks for proposing such rework. We need discussions on that topic. So I ask some questions below. > Following are the goals it tries to accomplish: > - Create a library containing core DPDK libraries (librte_eal, > librte_malloc, librte_mempool, librte_mbuf and librte_ring). > The idea of core libraries is to group those libraries that are > always required for any DPDK application. How is it better? Is it only to reduce dependencies lines? > - Remove config option to build a combined library. Why removing combined library? Is there people finding it helpful? > - For shared libraries, explicitly link against dependant > libraries (adding entries to DT_NEEDED). OK, good. > - Update app linking flags against static/shared DPDK libs. > > Note that this patch turns up being quite big because of moving lib > directories to a new subdirectory. > I have ommited the actual diff from the patch doing the move of librte_eal > as it is quite big (6MB). Probably a different approach is preferred. Why do you think moving directories is needed? Thanks -- Thomas