From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v7 2/2] app/test_pmd: add tests for new API's
Date: Tue, 11 Oct 2016 18:32:10 +0200
Message-ID: <1615821.fhDo4YvI1t@xps13>
References: <1475231418-30717-2-git-send-email-bernard.iremonger@intel.com>
 <2850526.ogb5UjoHqb@xps13>
 <8CEF83825BEC744B83065625E567D7C21A090A8A@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>, dev@dpdk.org, "Shah,
 Rahul R" <rahul.r.shah@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
 "az5157@att.com" <az5157@att.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qk0-f179.google.com (mail-qk0-f179.google.com
 [209.85.220.179]) by dpdk.org (Postfix) with ESMTP id 7F0162BCE
 for <dev@dpdk.org>; Tue, 11 Oct 2016 18:32:14 +0200 (CEST)
Received: by mail-qk0-f179.google.com with SMTP id f128so40583634qkb.1
 for <dev@dpdk.org>; Tue, 11 Oct 2016 09:32:14 -0700 (PDT)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C21A090A8A@IRSMSX108.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-10-11 15:51, Iremonger, Bernard:
> Hi Thomas,
> 
> <snip>
> 
> > Subject: Re: [dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests for new
> > API's
> > 
> > 2016-10-11 16:09, Ferruh Yigit:
> > > This will cause a compilation error for shared libraries. Because PMDs
> > > not linked against application when compiled as shared library but
> > > used as plugins.
> > >
> > > Since it has been decided to have NIC specific APIs, we need to
> > > re-work that approach to fix shared library compilation.
> > 
> > If testpmd uses the ixgbe API, it must be linked with the PMD.
> > Is there any issue adapting the testpmd makefile?
> > Hope that dlopen an already linked PMD is nicely managed.
> 
> The ixgbe API will  be used by other apps, for example Virtual Function Daemon (VFD)
> Moving the following line in rte.app.mak solves the problem
> 
> Line 117: _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD)      += -lrte_pmd_ixgbe
> 
> To Line 103.
> 
> Will this be acceptable?

I think we must not link PMD in the general case but let this
responsibility to the application in case it uses some specific
functions.
Does it make sense?