From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2] e1000: fix build with clang
Date: Wed, 25 May 2016 18:04:14 +0200
Message-ID: <1617188.mGNhOEY9vJ@xps13>
References: <1464101290-28547-1-git-send-email-h.mikita89@gmail.com>
 <1464189938-1769-1-git-send-email-h.mikita89@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: wenzhuo.lu@intel.com, dev@dpdk.org
To: Hiroyuki Mikita <h.mikita89@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41])
 by dpdk.org (Postfix) with ESMTP id B3DC92C19
 for <dev@dpdk.org>; Wed, 25 May 2016 18:04:16 +0200 (CEST)
Received: by mail-wm0-f41.google.com with SMTP id n129so190016899wmn.1
 for <dev@dpdk.org>; Wed, 25 May 2016 09:04:16 -0700 (PDT)
In-Reply-To: <1464189938-1769-1-git-send-email-h.mikita89@gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-05-26 00:25, Hiroyuki Mikita:
> GCC_VERSION is empty in case of clang:
> 	/bin/sh: line 0: test: -ge: unary operator expected
> 
> It is the same issue as http://dpdk.org/dev/patchwork/patch/5994/
> 
> Fixes: 366113dbfb69 ("e1000: suppress misleading indentation warning")
> 
> Signed-off-by: Hiroyuki Mikita <h.mikita89@gmail.com>
> ---
> v2:
> * fix for cross compier

The output of git grep '(CC)' shows that there is some room for
cross-compilation fixes.
Any volunteer?

> +ifeq ($(findstring gcc, $(CC)), gcc)
>  ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1)

Looks good, thanks