From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] mk: fix scope of disabling AVX512F support
Date: Wed, 19 Dec 2018 21:28:48 +0100
Message-ID: <1618982.fK5yx7iQXf@xps>
References: <20181219192904.61934-1-ferruh.yigit@intel.com>
 <1772993.ZpFq8iN2Ki@xps> <0ee900c3-57eb-9c89-0b0f-7f724c095d6b@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, stable@dpdk.org, Tom Barbette <barbette@kth.se>,
 Yongseok Koh <yskoh@mellanox.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <0ee900c3-57eb-9c89-0b0f-7f724c095d6b@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

19/12/2018 21:20, Ferruh Yigit:
> On 12/19/2018 7:58 PM, Thomas Monjalon wrote:
> > 19/12/2018 20:29, Ferruh Yigit:
> >> AVX512 was disabled for GCC because of Bugzilla issue 97 [1],
> >> the GCC defect submitted for the issue [2] highlighted that this is
> >> a known binutils version 2.30 issue.
> >>
> >> Narrowed the scope of no-avx512 to the this specific binutils version.
> > [...]
> >>  # disable AVX512F support of gcc as a workaround for Bug 97
> >>  ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
> >> +ifneq ($(filter 2.30%,$(LD_VERSION)),)
> >>  MACHINE_CFLAGS += -mno-avx512f
> > 
> > I think we should print a warning here.
> > There is a function $(warning) or $(info) for such case.
> 
> I can add but it prints warning per component, so it prints a lot.

I think we can choose to print only when compiling EAL
by checking $(findstring eal,$(lastword $(MAKEFILE_LIST)))

One more comment: it would be good to have this fix with meson too.