From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] config: remove duplicate configuration information Date: Thu, 03 Mar 2016 18:05:53 +0100 Message-ID: <16212811.xzAJdxdDBC@xps13> References: <1456149217-24833-1-git-send-email-keith.wiles@intel.com> <4B0EE92D-AF2B-41CC-A592-6A842AAB334A@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Wiles, Keith" Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 3C4612BA0 for ; Thu, 3 Mar 2016 18:07:32 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id l68so40199654wml.1 for ; Thu, 03 Mar 2016 09:07:32 -0800 (PST) In-Reply-To: <4B0EE92D-AF2B-41CC-A592-6A842AAB334A@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-03 14:43, Wiles, Keith: > >In order to cleanup the configuration files some and reduce > >the number of duplicate configuration information. Add a new > >file called common_base which contains just about all of the > >configuration lines in one place. Then have the common_bsdapp, > >common_linuxapp files include this one file. Then in those OS > >specific files add the delta configuration lines. > > Ping. I got a +1 for this patch just trying to get someone else to agree and ack. I know the current stuff kind of works, but it does require modifying multiple files and while moving this to a single place to modify I did find at least on different. > > I would like to see this one go in unless it just does not make any sense. You have my +1 I'm going to review it.