From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v15 0/3] mempool: add mempool handler feature Date: Wed, 22 Jun 2016 10:02:31 +0200 Message-ID: <1624460.4tjituxyrE@xps13> References: <1466171618-27358-1-git-send-email-david.hunt@intel.com> <1466337953-111495-1-git-send-email-david.hunt@intel.com> <1565408.6y3gpXryvJ@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, olivier.matz@6wind.com, viktorin@rehivetech.com, jerin.jacob@caviumnetworks.com, shreyansh.jain@nxp.com To: David Hunt Return-path: Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) by dpdk.org (Postfix) with ESMTP id 03CF98D86 for ; Wed, 22 Jun 2016 10:02:34 +0200 (CEST) Received: by mail-lf0-f52.google.com with SMTP id h129so65090346lfh.1 for ; Wed, 22 Jun 2016 01:02:33 -0700 (PDT) In-Reply-To: <1565408.6y3gpXryvJ@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-06-22 09:56, Thomas Monjalon: > 2016-06-19 13:05, David Hunt: > > v15 changes: > > > > * Changed rte_mempool_ops_get() to rte_mempool_get_ops() > > I don't find this change in the patch. > But I wonder wether it is really needed. If we assume that rte_mempool_ops_* are wrappers on top of handlers, rte_mempool_ops_get and rte_mempool_ops_register should be renamed to rte_mempool_get_ops and rte_mempool_register_ops.