From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCHv7 1/6] pmdinfogen: Add buildtools and pmdinfogen utility Date: Thu, 16 Jun 2016 17:06:49 +0300 Message-ID: <1624507a-dcfe-ec4d-3d61-a532130a3cc0@redhat.com> References: <1463431287-4551-1-git-send-email-nhorman@tuxdriver.com> <1465494421-6210-1-git-send-email-nhorman@tuxdriver.com> <1465494421-6210-2-git-send-email-nhorman@tuxdriver.com> <2e4a75e2-54fb-e449-a146-5b7bdf47f9f2@redhat.com> <20160616133343.GA20718@neilslaptop.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Bruce Richardson , Thomas Monjalon , Stephen Hemminger To: Neil Horman Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 9BF4DC75E for ; Thu, 16 Jun 2016 16:06:53 +0200 (CEST) In-Reply-To: <20160616133343.GA20718@neilslaptop.think-freely.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06/16/2016 04:33 PM, Neil Horman wrote: > On Thu, Jun 16, 2016 at 03:29:57PM +0300, Panu Matilainen wrote: >> On 06/09/2016 08:46 PM, Neil Horman wrote: >>> pmdinfogen is a tool used to parse object files and build json strings for >>> use in later determining hardware support in a dso or application binary. >>> pmdinfo looks for the non-exported symbol names this_pmd_name and >>> this_pmd_tbl (where n is a integer counter). It records the name of >>> each of these tuples, using the later to find the symbolic name of the >>> pci_table for physical devices that the object supports. With this >>> information, it outputs a C file with a single line of the form: >>> >>> static char *_driver_info[] __attribute__((used)) = " \ >>> PMD_DRIVER_INFO="; >>> >>> Where is the arbitrary name of the pmd, and is the >>> json encoded string that hold relevant pmd information, including the pmd >>> name, type and optional array of pci device/vendor ids that the driver >>> supports. >>> >>> This c file is suitable for compiling to object code, then relocatably >>> linking into the parent file from which the C was generated. This creates >>> an entry in the string table of the object that can inform a later tool >>> about hardware support. >>> >>> Signed-off-by: Neil Horman >>> CC: Bruce Richardson >>> CC: Thomas Monjalon >>> CC: Stephen Hemminger >>> CC: Panu Matilainen >>> --- >> >> Unlike earlier versions, pmdinfogen ends up installed in bindir during "make >> install". Is that intentional, or just a side-effect from using >> rte.hostapp.mk? If its intentional it probably should be prefixed with dpdk_ >> like the other tools. >> > Im not sure what the answer is here. As you can see, Thomas and I argued at > length over which makefile to use, and I gave up, so I suppose you can call it > intentional. Being in bindir makes a reasonable amount of sense I suppose, as > 3rd party developers can use it during their independent driver development. Right, it'd be useful for 3rd party driver developer, so lets consider it intentional :) > I'm not sure I agree with prefixing it though. Given that the hostapp.mk file > installs everything there, and nothing that previously used that make file had a > dpdk_ prefix that I can tell, I'm not sure why this would. pmdinfogen seems > like a pretty unique name, and I know of no other project that uses the term pmd > to describe anything. I agree about "pmd" being fairly unique as is, but if pmdinfo is dpdk_ prefixed then this should be too, or neither should be prefixed. I dont personally care which way, but it should be consistent. - Panu - > > Neil > >> - Panu - >> >>