From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] mk: suppress reference of packed members
Date: Mon, 16 Jan 2017 16:33:53 +0100
Message-ID: <1625382.2NysoX1o8M@xps13>
References: <1484509675-15075-1-git-send-email-emmanuel.roullit@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Emmanuel Roullit <emmanuel.roullit@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com
 [209.85.215.46]) by dpdk.org (Postfix) with ESMTP id 682F514EC
 for <dev@dpdk.org>; Mon, 16 Jan 2017 16:33:55 +0100 (CET)
Received: by mail-lf0-f46.google.com with SMTP id n124so17467656lfd.2
 for <dev@dpdk.org>; Mon, 16 Jan 2017 07:33:55 -0800 (PST)
In-Reply-To: <1484509675-15075-1-git-send-email-emmanuel.roullit@gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

2017-01-15 20:47, Emmanuel Roullit:
> error: taking address of packed member 'mlock' of class or structure
> 'rte_mem_config' may result in an unaligned pointer value
> [-Werror,-Waddress-of-packed-member]

Is it a compilation error?
Which compiler version?

> --- a/mk/toolchain/clang/rte.vars.mk
> +++ b/mk/toolchain/clang/rte.vars.mk
> @@ -67,7 +67,7 @@ WERROR_FLAGS := -W -Wall -Wstrict-prototypes -Wmissing-prototypes
>  WERROR_FLAGS += -Wmissing-declarations -Wold-style-definition -Wpointer-arith
>  WERROR_FLAGS += -Wnested-externs -Wcast-qual
>  WERROR_FLAGS += -Wformat-nonliteral -Wformat-security
> -WERROR_FLAGS += -Wundef -Wwrite-strings
> +WERROR_FLAGS += -Wundef -Wwrite-strings -Wno-address-of-packed-member

Why removing the warning?
Is there something to fix in the code?