From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v4 02/10] ethdev: update xstats_get() strings
	and Q handling
Date: Mon, 02 Nov 2015 08:59:26 +0100
Message-ID: <1625667.g6rLv7AGl4@xps13>
References: <1445528914-27636-2-git-send-email-harry.van.haaren@intel.com>
 <1446204998-17151-1-git-send-email-harry.van.haaren@intel.com>
 <1446204998-17151-3-git-send-email-harry.van.haaren@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Harry van Haaren <harry.van.haaren@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id 2459537AF
 for <dev@dpdk.org>; Mon,  2 Nov 2015 09:12:23 +0100 (CET)
Received: by wmeg8 with SMTP id g8so52023773wme.0
 for <dev@dpdk.org>; Mon, 02 Nov 2015 00:12:23 -0800 (PST)
In-Reply-To: <1446204998-17151-3-git-send-email-harry.van.haaren@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-10-30 11:36, Harry van Haaren:
> +       /* if xstats_get() is implemented by the PMD, the Q stats are done */
> +       if (dev->dev_ops->xstats_get != NULL)
> +               return count + xcount;
> +
>         /* per-rxq stats */
>         for (q = 0; q < dev->data->nb_rx_queues; q++) {
>                 for (i = 0; i < RTE_NB_RXQ_STATS; i++) {

Please could you explain why the generic per-queue stats are not used when
xstats is implemented in the driver?