From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] app/testpmd: set and clear keep CRC offload flag Date: Wed, 01 Aug 2018 16:22:53 +0200 Message-ID: <1631329.C8Q0lmT8f5@xps> References: <1533111199-4621-1-git-send-email-bernard.iremonger@intel.com> <239fdbf4-dd8f-97c7-58d6-dfaefb28fe3d@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Andrew Rybchenko , ferruh.yigit@intel.com, allain.legacy@windriver.com To: Bernard Iremonger Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6E9637EC7 for ; Wed, 1 Aug 2018 16:22:59 +0200 (CEST) In-Reply-To: <239fdbf4-dd8f-97c7-58d6-dfaefb28fe3d@solarflare.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/08/2018 10:22, Andrew Rybchenko: > On 01.08.2018 11:13, Bernard Iremonger wrote: > > If the "port config all crc-strip on" command is issued, > > The DEV_RX_OFFLOAD_KEEP_CRC offload flag should be cleared. > > > > If the "port config all crc-strip off command is issued, > > The DEV_RX_OFFLOAD_KEEP_CRC offload flag should be set. > > > > Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") > > Signed-off-by: Bernard Iremonger > > Acked-by: Andrew Rybchenko Applied, thanks