From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] pipeline: add statistics for librte_pipeline Date: Fri, 05 Jun 2015 12:30:35 +0200 Message-ID: <1633235.huhZUFEmyt@xps13> References: <3EB4FA525960D640B5BDFFD6A3D891263236E6CA@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Rajagopalan Sivaramakrishnan To: "Dumitrescu, Cristian" Return-path: Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 822A02A5F for ; Fri, 5 Jun 2015 12:31:28 +0200 (CEST) Received: by wgme6 with SMTP id e6so53343143wgm.2 for ; Fri, 05 Jun 2015 03:31:28 -0700 (PDT) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891263236E6CA@IRSMSX108.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-05-28 19:26, Dumitrescu, Cristian: > I think we have the following options identified so far for stats collection configuration: > > 1. Stats configuration through the RTE_LOG_LEVEL > 2. Single configuration flag global for all DPDK libraries > 3. Single configuration flag per DPDK library > > It would be good if Thomas and Stephen, as well as others, would reply with their preference order. There are important design questions in these threads. I think that the best way to come to a conclusion is to submit a design rule - to state whether statistics must be considered as a feature or as debug, - and to decide whether stats must be always available or disabled globally or per-library. It should be written in a new doc. I suggest docs/guidelines/design.rst. Then we'll have to discuss and vote on this base. It will avoid future discussions. The underlying discussion is to decide if every cycle is important even if there is a real usability drawback. In order to reach a conclusion, it seems reasonnable to target a consensus 2 weeks after the first submission of these design rules. Thanks Cristian to follow up.