From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 1/4] ethdev: add retrieving xstats by group
	and xstats by name
Date: Mon, 06 Mar 2017 11:17:54 +0100
Message-ID: <1634037.UG6F3tOjLg@xps13>
References: <1488545672-5208-1-git-send-email-kubax.kozak@intel.com>
 <1488545672-5208-2-git-send-email-kubax.kozak@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Kuba Kozak <kubax.kozak@intel.com>,
 Jacek Piasecki <jacekx.piasecki@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id E8D41108A
 for <dev@dpdk.org>; Mon,  6 Mar 2017 11:17:56 +0100 (CET)
Received: by mail-wm0-f48.google.com with SMTP id v186so59727440wmd.0
 for <dev@dpdk.org>; Mon, 06 Mar 2017 02:17:56 -0800 (PST)
In-Reply-To: <1488545672-5208-2-git-send-email-kubax.kozak@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

2017-03-03 13:54, Kuba Kozak:
> From: Jacek Piasecki <jacekx.piasecki@intel.com>
> 
> This patch extends library for retriving xstats by specified groups and
> single xstat by given name.
> 
> Signed-off-by: Jacek Piasecki <jacekx.piasecki@intel.com>
> Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>

As you probably know, it is difficult to have a good review
(or a simple review at all).
The most difficult part in such a change is not writing the code,
it is explaining your idea and getting people to agree.
Please show you have thought about the API, seen an issue or a lack,
and propose an idea with a clear target.
In short, we are missing a "why" and "how".

You must also explain what is a group, better than a list of #define.