From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eventdev: fix missing includes
Date: Fri, 04 Aug 2017 12:44:32 +0200
Message-ID: <1636294.pvSmynGaLT@xps>
References: <20170804102035.4051-1-thomas@monjalon.net>
 <20170804103521.GA5144@jerin>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 95CE32C19
 for <dev@dpdk.org>; Fri,  4 Aug 2017 12:44:36 +0200 (CEST)
In-Reply-To: <20170804103521.GA5144@jerin>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

04/08/2017 12:35, Jerin Jacob:
> -----Original Message-----
> > Date: Fri,  4 Aug 2017 12:20:35 +0200
> > From: Thomas Monjalon <thomas@monjalon.net>
> > To: jerin.jacob@caviumnetworks.com
> > Cc: dev@dpdk.org
> > Subject: [PATCH] eventdev: fix missing includes
> > X-Mailer: git-send-email 2.13.2
> >=20
> > The PCI helper file depends on some EAL definitions.
> > Spotted with devtools/check-includes.sh:
> > 	error: implicit declaration of function =E2=80=98rte_eal_process_type=
=E2=80=99
> > 	error: =E2=80=98RTE_PROC_PRIMARY=E2=80=99 undeclared
> > 	error: implicit declaration of function =E2=80=98rte_socket_id=E2=80=99
> >=20
> > There was also this error because the inline keyword was missing:
> > 	error: =E2=80=98rte_event_pmd_pci_probe=E2=80=99 defined but not used
> >=20
> > Fixes: 9a8269d56942 ("eventdev: make PCI probe and remove functions opt=
ional")
> >=20
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> >  lib/Makefile                               | 2 +-
> >  lib/librte_eventdev/rte_eventdev_pmd_pci.h | 4 +++-
> >  2 files changed, 4 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/lib/Makefile b/lib/Makefile
> > index 86caba17b..22962910d 100644
> > --- a/lib/Makefile
> > +++ b/lib/Makefile
> > @@ -69,7 +69,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_IP_FRAG) +=3D librte_ip_frag
> >  DEPDIRS-librte_ip_frag :=3D librte_eal librte_mempool librte_mbuf libr=
te_ether
> >  DEPDIRS-librte_ip_frag +=3D librte_hash
> >  DIRS-$(CONFIG_RTE_LIBRTE_GRO) +=3D librte_gro
> > -DEPDIRS-librte_gro :=3D librte_eal librte_mbuf librte_ether librte_net
> > +DEPDIRS-librte_gro :=3D librte_eal librte_mbuf
>=20
> Looks like unrelated change. Right?

Yes you're right.
I wanted to remove this wrong part of the patch and forgot.
Will send a v2, thanks