From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] dev: don't try to rollback a device attach
	that failed
Date: Sun, 25 Nov 2018 13:10:07 +0100
Message-ID: <1637860.pyqJGB34pm@xps>
References: <20181121190507.61845-1-dariusz.stojaczyk@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, qi.z.zhang@intel.com
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E0A9A1B675
 for <dev@dpdk.org>; Sun, 25 Nov 2018 13:10:09 +0100 (CET)
In-Reply-To: <20181121190507.61845-1-dariusz.stojaczyk@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

21/11/2018 20:05, Darek Stojaczyk:
> If a device fails to attach before it's plugged,
> the subsequent rollback will still try to detach it,
> causing a segfault. Unplugging a device that wasn't
> plugged isn't really supported, so this patch adds
> an extra error check to prevent that from happening.
> 
> While here, fix this also for normal (non-rollback)
> detach, which could also theoretically segfault on
> non-plugged device.
> 
> Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
> Cc: qi.z.zhang@intel.com
> 
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>

Applied, thanks