From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] examples: fix RSS hash function configuration
Date: Fri, 29 Jun 2018 01:55:54 +0200
Message-ID: <1639218.dJ5v8slQoU@xps>
References: <20180620150122.45945-1-ferruh.yigit@intel.com>
 <CAGyogRZD1L5EWNd8EsNGuapGq+U=_BiiE-xt=rNuuA7Nd8GPdA@mail.gmail.com>
 <6fcf5346-318b-d773-82ee-d28489d6b2ae@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Dan Gora <dg@adax.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id AD7F47EC7
 for <dev@dpdk.org>; Fri, 29 Jun 2018 01:55:56 +0200 (CEST)
In-Reply-To: <6fcf5346-318b-d773-82ee-d28489d6b2ae@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

20/06/2018 19:15, Ferruh Yigit:
> On 6/20/2018 6:07 PM, Dan Gora wrote:
> > Hi Ferruh,
> > 
> > The documentation for rte_eth_dev_configure() should get updated as
> > well to document this requirement to strip the unsupported RSS hash
> > function bits.  The current documentation only refers to the tx/rx
> > offload bits:
> > 
> >  *     -  Any offloading set in eth_conf->[rt]xmode.offloads must be within
> >  *        the [rt]x_offload_capa returned from rte_eth_dev_infos_get().
> >  *        Any type of device supported offloading set in the input argument
> >  *        eth_conf->[rt]xmode.offloads to rte_eth_dev_configure() is enabled
> >  *        on all queues and it can't be disabled in rte_eth_[rt]x_queue_setup().
> 
> Agreed, will update the patch according.

I don't see the doc updated in your v2.