From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 12/15] mbuf: rename data address helpers
	to IOVA
Date: Mon, 06 Nov 2017 17:03:33 +0100
Message-ID: <1640645.LeVPPqOgGX@xps>
References: <20170814151537.29454-1-santosh.shukla@caviumnetworks.com>
 <20171106014141.13266-13-thomas@monjalon.net>
 <20171106155646.bvjt2pri2n3gejp6@platinum>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Santosh Shukla <santosh.shukla@caviumnetworks.com>,
 sergio.gonzalez.monroy@intel.com, anatoly.burakov@intel.com, dev@dpdk.org
To: Olivier MATZ <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id D1D801B2E2
 for <dev@dpdk.org>; Mon,  6 Nov 2017 17:03:34 +0100 (CET)
In-Reply-To: <20171106155646.bvjt2pri2n3gejp6@platinum>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

06/11/2017 16:56, Olivier MATZ:
> On Mon, Nov 06, 2017 at 02:41:38AM +0100, Thomas Monjalon wrote:
> > The following inline functions and macros have been renamed to be
> > consistent with the IOVA wording:
> > 
> > rte_mbuf_data_dma_addr         -> rte_mbuf_data_iova
> > rte_mbuf_data_dma_addr_default -> rte_mbuf_data_iova_default
> > rte_pktmbuf_mtophys            -> rte_pktmbuf_iova
> > rte_pktmbuf_mtophys_offset     -> rte_pktmbuf_iova_offset
> > 
> > The deprecated functions and macros are kept to avoid breaking the API.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Same here, there are some remaining references after I apply the patches
> (maybe we are not on the same base commit id).
> 
> $ git grep 'mbuf.*phys'
> ...
> lib/librte_mbuf/rte_mbuf.c:     fprintf(f, "dump mbuf at %p, phys=%"PRIx64", buf_len=%u\n",
> ...
> test/test/test_cryptodev.h:pktmbuf_mtophys_offset(struct rte_mbuf *mbuf, int offset) {
> test/test/test_cryptodev.h:             printf("pktmbuf_mtophys_offset: offset out of buffer\n");
> test/test/test_cryptodev_blockcipher.c:                         pktmbuf_mtophys_offset(iobuf,
> test/test/test_cryptodev_blockcipher.c:                         pktmbuf_mtophys_offset(sym_op->m_src,

You are right.
I will fix those occurences.
Thanks for the review.