From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 5/7] net/virtio_user: add vhost kernel
	support
Date: Tue, 10 Jan 2017 09:46:30 +0100
Message-ID: <1642339.XEY7yvBjzp@xps13>
References: <1480689075-66977-1-git-send-email-jianfeng.tan@intel.com>
 <46af618f-c01b-3571-78fc-12d10859a4a1@redhat.com>
 <4fa4d06c-d359-df12-a073-7c2c2540b634@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Jason Wang <jasowang@redhat.com>, yuanhan.liu@linux.intel.com,
 ferruh.yigit@intel.com, cunming.liang@intel.com
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id E70C420F
 for <dev@dpdk.org>; Tue, 10 Jan 2017 09:46:38 +0100 (CET)
Received: by mail-wm0-f48.google.com with SMTP id k184so151525007wme.1
 for <dev@dpdk.org>; Tue, 10 Jan 2017 00:46:38 -0800 (PST)
In-Reply-To: <4fa4d06c-d359-df12-a073-7c2c2540b634@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-01-10 14:11, Tan, Jianfeng:
> On 1/9/2017 12:39 PM, Jason Wang wrote:
> > On 2016=E5=B9=B412=E6=9C=8823=E6=97=A5 15:14, Jianfeng Tan wrote:
> [...]
> >> +/* TUNSETIFF ifr flags */
> >> +#define IFF_TAP          0x0002
> >> +#define IFF_NO_PI        0x1000
> >> +#define IFF_ONE_QUEUE    0x2000
> >> +#define IFF_VNET_HDR     0x4000
> >> +#define IFF_MULTI_QUEUE  0x0100
> >> +#define IFF_ATTACH_QUEUE 0x0200
> >> +#define IFF_DETACH_QUEUE 0x0400
> >
> > Do we really want to duplicate those things which has been exposed =
by=20
> > uapi here?
>=20
> You mean those defined in <linux/if_tun.h>? Redefine those common=20
> macros, or include standard header file, with respective pros and con=
s.=20
> DPDK prefers the redefinition way as far as I understand, doesn't it?=


What is the benefit of copying defines instead of including?