From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform. Date: Tue, 09 Feb 2016 17:16:17 +0100 Message-ID: <1642628.fgbdceb2p5@xps13> References: <1450193851-9100-4-git-send-email-lsun@ezchip.com> <1452263438-21634-1-git-send-email-lsun@ezchip.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Liming Sun Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id B20121396 for ; Tue, 9 Feb 2016 17:17:41 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id 128so203201045wmz.1 for ; Tue, 09 Feb 2016 08:17:41 -0800 (PST) In-Reply-To: <1452263438-21634-1-git-send-email-lsun@ezchip.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Sorry for being late for commenting. 2016-01-08 09:30, Liming Sun: > -EZchip TILE-Gx > +EZchip TILE-Gx/Mx A comment about the TILE-Mx would be welcome. Is it supported currently? Isn't it an ARM arch? > M: Zhigang Lu > +M: Liming Sun > F: lib/librte_eal/common/include/arch/tile/ > F: drivers/net/mpipe/ [...] > +# Compile combined lib by default. > +CONFIG_RTE_BUILD_COMBINE_LIBS=y Why forcing this option in the defconfig file? [...] > ARCH ?= tile > + > +HOST_ARCH := ${shell uname -m} > +ifneq ($(filter tile%,${HOST_ARCH}),) > +CROSS = > +else > CROSS ?= tile- > +endif I don't think the CROSS variable should have a default value. It really depends on the toolchain. Talking about the toolchain, is it possible to build DPDK with the provided binary toolchain http://www.tilera.com/scm/tilegx-x86_64.tar.bz2 ? This is the Tilera Open Source page: http://www.tilera.com/scm/