From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tan, Jianfeng" Subject: Re: [PATCH v4 6/8] virtio-user: add new virtual pci driver for virtio Date: Fri, 13 May 2016 10:00:55 +0800 Message-ID: <16426a78-7b0d-51e7-d0ce-d1de6c7c639c@intel.com> References: <1461892716-19122-1-git-send-email-jianfeng.tan@intel.com> <1461892716-19122-7-git-send-email-jianfeng.tan@intel.com> <20160512021208.GA17474@yliu-dev.sh.intel.com> <20160512200040-mutt-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Yuanhan Liu , dev@dpdk.org, Huawei Xie , rich.lane@bigswitch.com, nakajima.yoshihiro@lab.ntt.co.jp, p.fedin@samsung.com, ann.zhuangyanying@huawei.com, mukawa@igel.co.jp, nhorman@tuxdriver.com To: "Michael S. Tsirkin" Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E20017F00 for ; Fri, 13 May 2016 04:01:00 +0200 (CEST) In-Reply-To: <20160512200040-mutt-send-email-mst@redhat.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Michael, On 5/13/2016 1:02 AM, Michael S. Tsirkin wrote: > On Thu, May 12, 2016 at 03:08:05PM +0800, Tan, Jianfeng wrote: >> (2) It's more aligned to previous logic to hide the detail to differentiate >> modern/legacy device. > Why is there a need to support legacy interfaces at all? It's a container > so if it's in use one can be reasonably sure you have a new kernel. > No, there's no need. The added device, virtio-user, is parallel to legacy and modern device. But there's a feature bit inside vhost user protocol for vhost user to decide the length of header, current implementation by default set this feature bit. Thanks, Jianfeng