From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] eal/bsdapp: fix compilation on FreeBSD
Date: Mon, 11 May 2015 15:45:46 +0200
Message-ID: <1647994.EPP3JTkp5f@xps13>
References: <1430830054-28791-1-git-send-email-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com
 [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 51036C41E
 for <dev@dpdk.org>; Mon, 11 May 2015 15:46:27 +0200 (CEST)
Received: by wicmc15 with SMTP id mc15so28615523wic.1
 for <dev@dpdk.org>; Mon, 11 May 2015 06:46:27 -0700 (PDT)
In-Reply-To: <1430830054-28791-1-git-send-email-bruce.richardson@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> Fixes: 6065355a "pci: make device id tables const"
> 
> Following the above commit, compilation on FreeBSD with clang was broken,
> giving the error message:
> 
> .../lib/librte_eal/bsdapp/eal/eal_pci.c:438:16: fatal error: assigning to
>       'struct rte_pci_id *' from 'const struct rte_pci_id *' discards qualifiers
>       [-Wincompatible-pointer-types-discards-qualifiers]
>         for (id_table = dr->id_table ; id_table->vendor_id != 0; id_table++) {
>                       ^ ~~~~~~~~~~~~
> 
> This patch fixes the issue by adding "const" to the type of id_table.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks