From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/2] link bonding unit test fix Date: Fri, 01 Aug 2014 17:21:06 +0200 Message-ID: <1648009.TlCDtWYl7N@xps13> References: <1405954337-28488-1-git-send-email-declan.doherty@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Doherty, Declan" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-07-22 10:57, De Lara Guarch, Pablo: > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Declan Doherty > > > > fix for link bonding unit tests which are failing due to change introduced in > > rte_eth_dev_configure which now explicitly checks in pmd supports link status > > chnage interrupts. > > > > Also adds some common test macros to the test application for unit testing > > > > Declan Doherty (2): > > test app: > > bond: unit test suite fix > > Acked-by: Pablo de Lara Applied for version 1.7.1. > I would add that it may be a good idea to implement some of the changes made > in this unit test in other ones (use the new macros). Yes, it's cleaner with macros. It would be a good idea to translate existing unit tests like Declan did. Thanks -- Thomas