From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eventdev: fix missing includes Date: Sat, 05 Aug 2017 01:18:57 +0200 Message-ID: <1653708.1k2yq08C3Z@xps> References: <20170804102035.4051-1-thomas@monjalon.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: "Mcnamara, John" , "jerin.jacob@caviumnetworks.com" To: dev@dpdk.org Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 96265374F for ; Sat, 5 Aug 2017 01:18:58 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > The PCI helper file depends on some EAL definitions. > > Spotted with devtools/check-includes.sh: > > error: implicit declaration of function =E2=80=98rte_eal_process_type= =E2=80=99 > > error: =E2=80=98RTE_PROC_PRIMARY=E2=80=99 undeclared > > error: implicit declaration of function =E2=80=98rte_socket_id=E2=80=99 > >=20 > > There was also this error because the inline keyword was missing: > > error: =E2=80=98rte_event_pmd_pci_probe=E2=80=99 defined but not used > >=20 > > Fixes: 9a8269d56942 ("eventdev: make PCI probe and remove functions > > optional") > >=20 > > Signed-off-by: Thomas Monjalon >=20 >=20 > > Spotted with devtools/check-includes.sh: >=20 > That is a good reminder for people to add this to their patch workflow or= to some automated tests. >=20 > Acked-by: John McNamara Applied