From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Huawei Xie <huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v5 02/11] lib/librte_vhost: refactor vhost lib for subsequent transform
Date: Mon, 29 Sep 2014 22:00:55 +0200 [thread overview]
Message-ID: <1654692.MNslQ8lvdC@xps13> (raw)
In-Reply-To: <1774915.lz9MF51vUa@xps13>
2014-09-29 21:55, Thomas Monjalon:
> 2014-09-26 17:45, Huawei Xie:
> > This patch does simple split of the original vhost example source
> > files in vhost lib directory.
> > vhost rx/tx functions virtio_dev_rx/tx are copied from main.c to
> > new file vhost_rxtx.c and license header is added.
> > main.c and main.h are removed and will be copied to new vhost
> > example in subsequent patch.
> > virtio-net.h is renamed to rte_virtio_net.h as API header file.
> >
> > Signed-off-by: Huawei Xie <huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> You are removing functions for mergeable buffer feature.
> Please keep it instead of re-adding it later.
Other comment, you are silently increasing these values to 64:
#define MAX_PKT_BURST 32 /* Max burst size for RX/TX */
#define MAX_MRG_PKT_BURST 16 /* Max burst for merge buffers. Set to 1 due to performance issue. */
--
Thomas
next prev parent reply other threads:[~2014-09-29 20:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 9:45 [PATCH v5 00/11] user space vhost library and vhost example Huawei Xie
[not found] ` <1411724758-27488-1-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-26 9:45 ` [PATCH v5 01/11] lib/librte_vhost: move src files in vhost example to vhost lib directory Huawei Xie
[not found] ` <1411724758-27488-2-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-29 19:41 ` Thomas Monjalon
2014-09-30 2:07 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F2AF246-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-30 4:35 ` Thomas Monjalon
2014-09-26 9:45 ` [PATCH v5 02/11] lib/librte_vhost: refactor vhost lib for subsequent transform Huawei Xie
[not found] ` <1411724758-27488-3-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-29 19:55 ` Thomas Monjalon
2014-09-29 20:00 ` Thomas Monjalon [this message]
2014-09-26 9:45 ` [PATCH v5 03/11] lib/librte_vhost: vhost lib transform Huawei Xie
[not found] ` <1411724758-27488-4-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-29 19:51 ` Thomas Monjalon
2014-09-26 9:45 ` [PATCH v5 04/11] lib/librte_vhost: merge vhost merge-able rx. merge vhost tx fix Huawei Xie
2014-09-26 9:45 ` [PATCH v5 05/11] lib/librte_vhost: merge Oliver's mbuf change Huawei Xie
[not found] ` <1411724758-27488-6-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-29 19:44 ` Thomas Monjalon
2014-09-30 2:41 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F2AF2C0-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-30 3:41 ` Ouyang, Changchun
2014-09-30 4:46 ` Thomas Monjalon
2014-09-30 6:43 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F2AF638-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-30 8:06 ` Thomas Monjalon
2014-09-26 9:45 ` [PATCH v5 06/11] lib/librte_vhost: fixes serious coding style issues Huawei Xie
2014-09-26 9:45 ` [PATCH v5 07/11] lib/librte_vhost: add vhost support in DPDK makefile Huawei Xie
2014-09-26 9:45 ` [PATCH v5 08/11] examples/vhost: copy old vhost example src file Huawei Xie
2014-09-26 9:45 ` [PATCH v5 09/11] examples/vhost: vhost example based on vhost lib API Huawei Xie
2014-09-26 9:45 ` [PATCH v5 10/11] examples/vhost: merge oliver's mbuf changes to vhost example Huawei Xie
2014-09-26 9:45 ` [PATCH v5 11/11] examples/vhost: add vhost example Makefile Huawei Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1654692.MNslQ8lvdC@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).