From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] fm10k: fix the compilation on big endian
	platforms
Date: Mon, 03 Aug 2015 13:38:44 +0200
Message-ID: <16563190.8TBxXSHCrU@xps13>
References: <1438583517-19035-1-git-send-email-chaozhu@linux.vnet.ibm.com>
 <1533915.C0IUmFEqd8@xps13> <55BF5161.3000904@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Chao Zhu <chaozhu@linux.vnet.ibm.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
 [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 68799C3C4
 for <dev@dpdk.org>; Mon,  3 Aug 2015 13:39:59 +0200 (CEST)
Received: by wibxm9 with SMTP id xm9so117324456wib.0
 for <dev@dpdk.org>; Mon, 03 Aug 2015 04:39:59 -0700 (PDT)
In-Reply-To: <55BF5161.3000904@linux.vnet.ibm.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-08-03 19:32, Chao Zhu:
> On 2015/8/3 17:06, Thomas Monjalon wrote:
> > 2015-08-03 14:31, Chao Zhu:
> >> The rte_cpu_to_le_32 function can't be used to define const variables
> >> because it has different implementation on big endian platforms. If
> >> doing so, it will cause 'initializer element is not constant' compiling
> >> error. This patch fixes this problem.
> >> --- a/drivers/net/fm10k/base/fm10k_tlv.c
> >> +++ b/drivers/net/fm10k/base/fm10k_tlv.c
> > 
> > You cannot change a base driver file except the osdep header where
> > FM10K_CPU_TO_LE32 is defined.
> >
> > I don't understand why it doesn't give you a constant, given this definition:
> >
> > #define rte_bswap32(x) ((uint32_t)(__builtin_constant_p(x) ?        \
> >                     rte_constant_bswap32(x) :        \
> >                     rte_arch_bswap32(x)))
> >
> > Have you tried CONFIG_RTE_FORCE_INTRINSICS=y ?
> > It should trigger this definition:
> >
> > #define rte_bswap32(x) __builtin_bswap32(x)
> 
> Yes.  CONFIG_RTE_FORCE_INTRINSICS=y works on Power Big endian.  But if I 
> turn off this, the error happens.  Seems rte_constant_bswap32 doesn't 
> work on Power8? I'll try to check it.

The tile arch force intrinsics:
	http://dpdk.org/browse/dpdk/tree/config/defconfig_tile-tilegx-linuxapp-gcc#n39
	http://dpdk.org/browse/dpdk/tree/lib/librte_eal/common/include/arch/tile/rte_byteorder.h#n36
I don't know wether it was for the same reason.