From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] net/qede: fix advertising link speed capability Date: Mon, 07 Nov 2016 20:48:48 +0100 Message-ID: <1656706.VhxROYD8UU@xps13> References: <1477721677-25668-1-git-send-email-Rasesh.Mody@cavium.com> <1477938901-24999-1-git-send-email-Rasesh.Mody@cavium.com> <1477938901-24999-2-git-send-email-Rasesh.Mody@cavium.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: bruce.richardson@intel.com, dev@dpdk.org, Dept-EngDPDKDev@qlogic.com To: Rasesh Mody , Harish Patil Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id BFB021E33 for ; Mon, 7 Nov 2016 20:48:50 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id a197so204138934wmd.0 for ; Mon, 07 Nov 2016 11:48:50 -0800 (PST) In-Reply-To: <1477938901-24999-2-git-send-email-Rasesh.Mody@cavium.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-10-31 11:35, Rasesh Mody: > From: Harish Patil > > Fix to advertise device's link speed capability based on NVM > port configuration instead of returning driver supported speeds. > > Fixes: 95e67b479506 ("net/qede: add 100G link speed capability") > > Signed-off-by: Harish Patil [...] > + /* Fill up the native advertised speed */ > + switch (params.speed.advertised_speeds) { > + case NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_10G: > + adv_speed = 10000; > + break; > + case NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_25G: > + adv_speed = 25000; > + break; > + case NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_40G: > + adv_speed = 40000; > + break; > + case NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_50G: > + adv_speed = 50000; > + break; > + case NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_BB_100G: > + adv_speed = 100000; > + break; > + default: > + DP_NOTICE(hwfn, false, "Unknown speed\n"); > + adv_speed = 0; > + } > + if_link->adv_speed = adv_speed; The qede devices support only one speed? I guess it is wrong but it is a step in right direction so it will be enough for 16.11. Applied