From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v14 1/6] lib: add information metrics library
Date: Wed, 05 Apr 2017 15:39:48 +0200
Message-ID: <165712131.qiFBceb8LK@xps13>
References: <1490907662-27666-1-git-send-email-remy.horton@intel.com>
 <1490907662-27666-2-git-send-email-remy.horton@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Remy Horton <remy.horton@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com
 [209.85.128.172]) by dpdk.org (Postfix) with ESMTP id C7CA31DB1
 for <dev@dpdk.org>; Wed,  5 Apr 2017 15:39:50 +0200 (CEST)
Received: by mail-wr0-f172.google.com with SMTP id w43so14616548wrb.0
 for <dev@dpdk.org>; Wed, 05 Apr 2017 06:39:50 -0700 (PDT)
In-Reply-To: <1490907662-27666-2-git-send-email-remy.horton@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-03-30 22:00, Remy Horton:
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -98,6 +98,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_RING)           += -lrte_ring
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_EAL)            += -lrte_eal
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_CMDLINE)        += -lrte_cmdline
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_REORDER)        += -lrte_reorder
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_METRICS)        += -lrte_metrics

It should not be added here in --whole-archive as it is not going to be
used by plugins (drivers).

I suggest moving it upper with rte_jobstats.