From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] devtools: fix meson build test to exit on failure Date: Wed, 13 Mar 2019 11:03:41 +0100 Message-ID: <1664387.3Zkg7kFagz@xps> References: <20190312100958.18751-1-bruce.richardson@intel.com> <20190312101828.18817-1-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id CE41D3572 for ; Wed, 13 Mar 2019 11:03:45 +0100 (CET) In-Reply-To: <20190312101828.18817-1-bruce.richardson@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/03/2019 11:18, Bruce Richardson: > When piping the ninja command through cat, we lose the error value from > the call to ninja in the case of failure. This prevents the script from > exiting at the first broken build. Fix this by setting the "pipefail" > shell option. > > Fixes: 4bcb9b768604 ("devtools: add verbose option to meson build test") > > Signed-off-by: Bruce Richardson Applied, thanks