From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 1/2] ethdev: add callback to get register size in bytes Date: Fri, 17 Jun 2016 12:20:18 +0200 Message-ID: <1667158.opORKPN5aG@xps13> References: <1464767771-19159-1-git-send-email-zr@semihalf.com> <575ED666.2010509@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Remy Horton , dev@dpdk.org To: Zyta Szpak Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 70BEA95CB for ; Fri, 17 Jun 2016 12:20:20 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id v199so224228247wmv.0 for ; Fri, 17 Jun 2016 03:20:20 -0700 (PDT) In-Reply-To: <575ED666.2010509@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-06-13 16:51, Remy Horton: > > On 12/06/2016 15:51, Zyta Szpak wrote: > > I would prefer having only one function rte_eth_dev_get_regs() > > which returns length and width if data is NULL. > > The first call is a parameter request before buffer allocation, > > and the second call fills the buffer. > > > > We can deprecate the old API and introduce this new one. > > > > Opinions? > > > > In my opinion as it is now it works fine. Gathering all parameters in > > one callback might be a good idea if the maintainer also agrees to that > > because as I mentioned, it interferes. > > From my perspective changing rte_eth_dev_get_regs() isn't a problem, as > it isn't used directly rather than through rte_ethtool_get_regs().. Zyta, would you like to make a v4?