From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v5 7/7] app/testpmd: check not detaching
	device twice
Date: Thu, 18 Oct 2018 03:45:26 +0200
Message-ID: <1667170.UpD0Izeecg@xps>
References: <20181007222554.4886-1-thomas@monjalon.net>
 <20181018013522.11253-1-thomas@monjalon.net>
 <20181018013522.11253-8-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: gaetan.rivet@6wind.com, ophirmu@mellanox.com, wisamm@mellanox.com,
 ferruh.yigit@intel.com, arybchenko@solarflare.com, bernard.iremonger@intel.com
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3642F1B104
 for <dev@dpdk.org>; Thu, 18 Oct 2018 03:45:25 +0200 (CEST)
In-Reply-To: <20181018013522.11253-8-thomas@monjalon.net>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

+Cc Bernard

18/10/2018 03:35, Thomas Monjalon:
> The command "port detach" is removing the EAL rte_device
> of the ethdev port specified as parameter.
> 
> After detaching, the pointer, which maps a port to its device,
> is resetted. This way, it is possible to check whether a port
> is still associated to a (not removed) device.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  app/test-pmd/testpmd.c | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index f241ce363..3093d3306 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2340,8 +2340,17 @@ setup_attached_port(portid_t pi)
>  void
>  detach_port(portid_t port_id)
>  {
> +	struct rte_device *dev;
> +	portid_t sibling;
> +
>  	printf("Detaching a port...\n");
>  
> +	dev = rte_eth_devices[port_id].device;
> +	if (dev == NULL) {
> +		printf("Device already removed\n");
> +		return;
> +	}
> +
>  	if (ports[port_id].port_status != RTE_PORT_CLOSED) {
>  		if (ports[port_id].port_status != RTE_PORT_STOPPED) {
>  			printf("Port not stopped\n");
> @@ -2352,10 +2361,14 @@ detach_port(portid_t port_id)
>  			port_flow_flush(port_id);
>  	}
>  
> -	if (rte_dev_remove(rte_eth_devices[port_id].device) != 0) {
> +	if (rte_dev_remove(dev) != 0) {
>  		TESTPMD_LOG(ERR, "Failed to detach port %u\n", port_id);
>  		return;
>  	}
> +	/* reset mapping between old ports and removed device */
> +	for (sibling = 0; sibling < RTE_MAX_ETHPORTS; sibling++)
> +		if (rte_eth_devices[sibling].device == dev)
> +			rte_eth_devices[sibling].device = NULL;
>  
>  	remove_unused_fwd_ports();