From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2 1/7]i40e:support VxLAN packet
	identification
Date: Wed, 27 Aug 2014 16:58:46 +0200
Message-ID: <1672259.DZkGQ2cZmA@xps13>
References: <1409038294-21693-1-git-send-email-jijiang.liu@intel.com>
 <1409038294-21693-2-git-send-email-jijiang.liu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Jijiang Liu <jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1409038294-21693-2-git-send-email-jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Jijiang,

2014-08-26 15:31, Jijiang Liu:
> VxLAN UDP port configuration on i40e, which include
>  -  VxLAN UDP port initialization
>  -  add APIs to configure VxLAN UDP port 

Actually you should explain that you introduce tunnels
and first one is VxLAN.

>  lib/librte_ether/rte_ethdev.c     |   63 ++++++++++++
>  lib/librte_ether/rte_ethdev.h     |   76 ++++++++++++++
>  lib/librte_ether/rte_ether.h      |   10 ++
>  lib/librte_pmd_i40e/i40e_ethdev.c |  199 ++++++++++++++++++++++++++++++++++++-
>  lib/librte_pmd_i40e/i40e_ethdev.h |    5 +

Changing ethdev API is so sensible that it deserves a separated commit.

Code seems OK.

Thanks
-- 
Thomas