From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal/linux: fix negative value for undetermined numa_node Date: Mon, 03 Aug 2015 19:19:46 +0200 Message-ID: <1673557.cjtS5G2rXq@xps13> References: <55BEC80E.5010309@intel.com> <20150803050441.GA8325@mhcomputing.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Matthew Hall , "Liang, Cunming" Return-path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 25D0BC39C for ; Mon, 3 Aug 2015 19:21:05 +0200 (CEST) Received: by wibxm9 with SMTP id xm9so131152534wib.0 for ; Mon, 03 Aug 2015 10:21:05 -0700 (PDT) In-Reply-To: <20150803050441.GA8325@mhcomputing.net> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-08-02 22:04, Matthew Hall: > On Mon, Aug 03, 2015 at 09:46:54AM +0800, Liang, Cunming wrote: > > According to the API definition, if the socket could not be determined, a > > default of zero will take. > > The '-1' is returned when the port_id value is out of range. > > Yes, but when I asked the exact same question and was told the documentation > was wrong not the -1 return value. It was an error. The correct API, as defined, is to return 0 when there is no NUMA. This patch now reverts this one: http://dpdk.org/browse/dpdk/commit/?id=a4ff75496a18 Thanks Matthew for helping to clarify it. > Sure, if nobody objects like the last time I asked. But this will change the > user behavior as I am looking for the -1 now. You're right. But this fix follows the defined API, so it's rather an API fix than an API break. Applied, thanks