From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v5 1/3] ethdev: new API to free consumed
	buffers in Tx ring
Date: Tue, 07 Mar 2017 17:03:57 +0100
Message-ID: <1673691.cTdATcOVfP@xps13>
References: <20170123211340.22570-1-bmcfall@redhat.com>
 <2417966.3G0haXHz4n@xps13>
 <CAKLkqD7D_QhvHCkdQ+QUSyxgjnoBLfZMUROZCvQvn8nTUFH2LQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: wenzhuo.lu@intel.com, olivier.matz@6wind.com, dev@dpdk.org,
 adrien.mazarguil@6wind.com
To: Billy McFall <bmcfall@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com
 [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id 67F371BBE
 for <dev@dpdk.org>; Tue,  7 Mar 2017 17:03:59 +0100 (CET)
Received: by mail-wr0-f179.google.com with SMTP id g10so4643331wrg.2
 for <dev@dpdk.org>; Tue, 07 Mar 2017 08:03:59 -0800 (PST)
In-Reply-To: <CAKLkqD7D_QhvHCkdQ+QUSyxgjnoBLfZMUROZCvQvn8nTUFH2LQ@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-03-07 09:29, Billy McFall:
> On Mon, Feb 27, 2017 at 8:48 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
> wrote:
> > I think you could use rte_errno (while keeping negative return codes).
> >
> 
> I can do that if you want, but if I understand your comment, it will make
> the implementation of the function not as clean. I cannot use the existing
> RTE_ETH_VALID_PORTID_OR_ERR_RET(..) and RTE_FUNC_PTR_OR_ERR_RET(..) MACROs
> because they are handling the return on error. Or am I missing something?

Yes. Maybe we need new macros for basic error management with rte_errno.