From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] qos_meter: Fix compilation with APP_MODE_FWD
Date: Tue, 25 Aug 2015 14:36:59 +0200
Message-ID: <1677849.ZVAMZEjUYk@xps13>
References: <1439913312-14761-1-git-send-email-ian.stokes@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id A2E085323
 for <dev@dpdk.org>; Tue, 25 Aug 2015 14:38:10 +0200 (CEST)
Received: by widdq5 with SMTP id dq5so13752393wid.0
 for <dev@dpdk.org>; Tue, 25 Aug 2015 05:38:10 -0700 (PDT)
In-Reply-To: <1439913312-14761-1-git-send-email-ian.stokes@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-08-18 16:55, Ian Stokes:
> The qos_meter sample app will fail to compile if APP_MODE
> is set to APP_MODE_FWD. This patch changes the variable
> name 'color' in main.h to the expected variable name
> 'input_color' to allow compilation with APP_MODE_FWD.

Thanks for raising the issue.

> --- a/examples/qos_meter/main.h
> +++ b/examples/qos_meter/main.h
>  #if APP_MODE == APP_MODE_FWD
>  
> -#define FUNC_METER(a,b,c,d) color, flow_id=flow_id, pkt_len=pkt_len, time=time
> +#define FUNC_METER(a,b,c,d) input_color, flow_id=flow_id, pkt_len=pkt_len, time=time

This patch should not be accepted to discourage build-time options.
Patch for run-time option is welcome.