From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v5 1/2] bond: add mode 4 support
Date: Mon, 24 Nov 2014 19:05:32 +0100
Message-ID: <1679332.pWPR9Gg93t@xps13>
References: <1416849181-17183-1-git-send-email-michalx.k.jastrzebski@intel.com>
 <1416849181-17183-2-git-send-email-michalx.k.jastrzebski@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Michal Jastrzebski <michalx.k.jastrzebski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
 Pawel Wodkowski <pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1416849181-17183-2-git-send-email-michalx.k.jastrzebski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-11-24 17:13, Michal Jastrzebski:
> From: Pawel Wodkowski <pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

As I've already requested, we need some explanations.
The minimum is to explain what is mode 4 or give inputs.
It won't be integrated without it. Wednesday is the deadline for this stuff.

> ---
>  lib/librte_ether/rte_ether.h                      |    1 +
>  lib/librte_pmd_bond/Makefile                      |    2 +
>  lib/librte_pmd_bond/rte_eth_bond.h                |    5 +
>  lib/librte_pmd_bond/rte_eth_bond_8023ad.c         | 1218 +++++++++++++++++++++
>  lib/librte_pmd_bond/rte_eth_bond_8023ad.h         |  214 ++++
>  lib/librte_pmd_bond/rte_eth_bond_8023ad_private.h |  308 ++++++
>  lib/librte_pmd_bond/rte_eth_bond_api.c            |   91 +-
>  lib/librte_pmd_bond/rte_eth_bond_args.c           |    1 +
>  lib/librte_pmd_bond/rte_eth_bond_pmd.c            |  262 ++++-
>  lib/librte_pmd_bond/rte_eth_bond_private.h        |   31 +-

For a such big development, there are probably some interesting things to
explain about design, performance, etc.
Be proud of your work!

-- 
Thomas