From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] devtools: list stable commits do not have fixline Date: Fri, 28 Apr 2017 10:15:46 +0200 Message-ID: <1679460.mJD8jeqIBn@xps> References: <1493364114-7771-1-git-send-email-yuanhan.liu@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Yuanhan Liu Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id AAD1F9E3 for ; Fri, 28 Apr 2017 10:15:48 +0200 (CEST) In-Reply-To: <1493364114-7771-1-git-send-email-yuanhan.liu@linux.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/04/2017 09:21, Yuanhan Liu: > Some commits for stable releases (with Cc stable tag) may not have the > fixline. For example: > http://dpdk.org/dev/patchwork/patch/23955/ > > It disables a feature we have implemented in last release. The feature > is done right. It's the QEMU implementaton being buggy, that we have to > disable it to workaround those buggy QEMU releases (v2.7 - v2.9). Without > such workaround, QEMU won't start when queue number >= 2. > > That said, we also have to backport it to stable releases, though there > is no fixline (there was no DPDK bug to fix after all). How do we know where should it be backported? It is fixing a bug with a correct implementation because of a buggy dependency. But it is still a bug. So I think we should put a Fixes: line. > > There should be similar cases like this. Thus, this patch makes > git-log-fixes.sh script also list those stable commits do not have > fixline. I am against putting Cc: stable without Fixes: line. However, this patch is harmless.