From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ethdev: cleanup device ops struct whitespace Date: Thu, 22 Dec 2016 12:18:27 +0100 Message-ID: <1679817.BkgAe1E4Dq@xps13> References: <20161208135940.17233-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Ferruh Yigit Return-path: Received: from mail-wj0-f178.google.com (mail-wj0-f178.google.com [209.85.210.178]) by dpdk.org (Postfix) with ESMTP id F1C8B10D19 for ; Thu, 22 Dec 2016 12:18:28 +0100 (CET) Received: by mail-wj0-f178.google.com with SMTP id ez4so7637174wjd.0 for ; Thu, 22 Dec 2016 03:18:28 -0800 (PST) In-Reply-To: <20161208135940.17233-1-ferruh.yigit@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-12-08 13:59, Ferruh Yigit: > - Grouped related items using empty lines I have few comments below. [...] > + > eth_dev_infos_get_t dev_infos_get; /**< Get device info. */ > eth_dev_supported_ptypes_get_t dev_supported_ptypes_get; > - /**< Get packet types supported and identified by device*/ > - mtu_set_t mtu_set; /**< Set MTU. */ > - vlan_filter_set_t vlan_filter_set; /**< Filter VLAN Setup. */ > - vlan_tpid_set_t vlan_tpid_set; /**< Outer/Inner VLAN TPID Setup. */ > + /**< Get packet types supported and identified by device. */ We could add a blank line here. > + mtu_set_t mtu_set; /**< Set MTU. */ > + [...] > + > + eth_udp_tunnel_port_add_t udp_tunnel_port_add; /** Add UDP tunnel port. */ > + eth_udp_tunnel_port_del_t udp_tunnel_port_del; /** Del UDP tunnel port. */ > + [...] > + > + reta_update_t reta_update; /** Update redirection table. */ > + reta_query_t reta_query; /** Query redirection table. */ > + > + eth_get_reg_t get_reg; /**< Get registers. */ > + eth_get_eeprom_length_t get_eeprom_length; /**< Get eeprom length. */ > + eth_get_eeprom_t get_eeprom; /**< Get eeprom data. */ > + eth_set_eeprom_t set_eeprom; /**< Set eeprom. */ > + [...] > + rss_hash_update_t rss_hash_update; /** Configure RSS hash protocols. */ > + rss_hash_conf_get_t rss_hash_conf_get; /** Get current RSS hash configuration. */ RSS should go above with RETA. > + eth_filter_ctrl_t filter_ctrl; /**< common filter control. */ > + eth_set_mc_addr_list_t set_mc_addr_list; /**< set list of mcast addrs. */ Should go with other MAC functions. [...] > + eth_timesync_enable_t timesync_enable; > /** Turn IEEE1588/802.1AS timestamping on. */ > - eth_timesync_enable_t timesync_enable; > + eth_timesync_disable_t timesync_disable; > /** Turn IEEE1588/802.1AS timestamping off. */ > - eth_timesync_disable_t timesync_disable; > - /** Read the IEEE1588/802.1AS RX timestamp. */ > eth_timesync_read_rx_timestamp_t timesync_read_rx_timestamp; > - /** Read the IEEE1588/802.1AS TX timestamp. */ > + /** Read the IEEE1588/802.1AS RX timestamp. */ > eth_timesync_read_tx_timestamp_t timesync_read_tx_timestamp; > + /** Read the IEEE1588/802.1AS TX timestamp. */ > + > + eth_get_dcb_info get_dcb_info; /** Get DCB information. */ DCB should not be in the middle of timesync functions. > + eth_timesync_adjust_time timesync_adjust_time; /** Adjust the device clock. */ > + eth_timesync_read_time timesync_read_time; /** Get the device clock time. */ > + eth_timesync_write_time timesync_write_time; /** Set the device clock time. */