From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] l2fwd-crypto: fix coverity defect
Date: Thu, 07 Apr 2016 19:51:44 +0200
Message-ID: <1681086.Z1ziI0Qxk5@xps13>
References: <1460035389-49395-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <57068423.4050007@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Declan Doherty <declan.doherty@intel.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id D7E732956
 for <dev@dpdk.org>; Thu,  7 Apr 2016 19:51:46 +0200 (CEST)
Received: by mail-wm0-f44.google.com with SMTP id l6so35595786wml.1
 for <dev@dpdk.org>; Thu, 07 Apr 2016 10:51:46 -0700 (PDT)
In-Reply-To: <57068423.4050007@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> > When parsing crypto device type, the string was being copied
> > with strcpy(), which could overflow the destination buffer
> > (which is 32 byte long), so snprintf() should be used instead.
> >
> > This fixes coverity issue 124575:
[...]
> > Fixes: commit 49f79e86480d ("examples/l2fwd-crypto: add missing string initialization")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >
> Acked-by: Declan Doherty <declan.doherty@intel.com>

Applied, thanks