From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v10 4/4] doc: add user-space ethtool sample
	app guide
Date: Tue, 08 Dec 2015 01:30:35 +0100
Message-ID: <16865404.Wo74zD9g5U@xps13>
References: <1449496140-11758-1-git-send-email-remy.horton@intel.com>
 <1449496140-11758-5-git-send-email-remy.horton@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id A1BE2FE5
 for <dev@dpdk.org>; Tue,  8 Dec 2015 01:31:48 +0100 (CET)
Received: by wmww144 with SMTP id w144so9345731wmw.0
 for <dev@dpdk.org>; Mon, 07 Dec 2015 16:31:48 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id da10sm480722wjb.22.2015.12.07.16.31.47
 for <dev@dpdk.org> (version=TLSv1/SSLv3 cipher=OTHER);
 Mon, 07 Dec 2015 16:31:47 -0800 (PST)
In-Reply-To: <1449496140-11758-5-git-send-email-remy.horton@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-12-07 13:49, Remy Horton:
> --- a/doc/guides/rel_notes/release_2_2.rst
> +++ b/doc/guides/rel_notes/release_2_2.rst
> @@ -243,6 +243,7 @@ Examples
>  
>  * **vhost_xen: Fixed compile error.**
>  
> +* **ethtool: Added ethtool shim and sample application.**
>  
>  Other
>  ~~~~~

There are really common errors I'm fixing before applying:
(seen in most of other recent patches)

- When adding an item, a separation new line is needed
(the double blank lines are on purpose).
- A new example or driver is not an issue (should not ;),
so it should be in the "features" section.
- If the doc is not too large, a separate commit is not needed.

I know these comments are not read but I keep the hope that the
next series from other authors will meet the expectations.