From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] examples: remove Rx checksum offload
Date: Mon, 30 Jul 2018 11:50:50 +0200
Message-ID: <1687236.JLa48GYJ5r@xps>
References: <20180729124409.3669-1-jerin.jacob@caviumnetworks.com>
 <2601191342CEEE43887BDE71AB977258DF51F641@irsmsx105.ger.corp.intel.com>
 <20180730093555.GA22823@jerin>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 "shahafs@mellanox.com" <shahafs@mellanox.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9544A4C9D
 for <dev@dpdk.org>; Mon, 30 Jul 2018 11:50:57 +0200 (CEST)
In-Reply-To: <20180730093555.GA22823@jerin>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

30/07/2018 11:35, Jerin Jacob:
> From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
> > >
> > > As of now, application does not check PKT_RX_*_CKSUM_* flags per
> > > packet, so it does not matter DEV_RX_OFFLOAD_CHECKSUM enabled or not.
> > >
> > > Removing DEV_RX_OFFLOAD_CHECKSUM offload so that driver can save a few
> > > cycles if possible.
> > 
> > Personally, I'd move in other direction: keep RX checksum offload and add
> > checks inside sample apps to handle (drop) packets with invalid checksum.
> 
> OK. Till someones add the DROP logic in application, Can we take
> this patch? Because there is no point in enabling DEV_RX_OFFLOAD_CHECKSUM
> without DROP or any meaning full action in application.

If there is no patch sent to use this offload on August 1st,
then I will apply this patch to remove the offload request.