dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Michal Jastrzebski
	<michalx.k.jastrzebski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v3 1/6] net: changed arp_hdr struct declaration
Date: Fri, 20 Feb 2015 15:30:36 +0100	[thread overview]
Message-ID: <1694402.UUemy3W7BY@xps13> (raw)
In-Reply-To: <1424366779-14256-2-git-send-email-michalx.k.jastrzebski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

2015-02-19 18:26, Michal Jastrzebski:
> From: Maciej Gajdzica <maciejx.t.gajdzica-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> Changed MAC address type from uint8_t[6] to struct ether_addr and IP
> address type from uint8_t[4] to uint32_t. Also removed union from
> arp_hdr struct. Updated test-pmd to match new arp_hdr version.
> 
> Signed-off-by: Maciej Gajdzica <maciejx.t.gajdzica-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Why?
"Changed A to B" is not a sufficient explanation.

  parent reply	other threads:[~2015-02-20 14:30 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-13 15:16 [PATCH v2 0/6] Link Bonding mode 6 support (ALB) Michal Jastrzebski
     [not found] ` <1423840570-6452-1-git-send-email-michalx.k.jastrzebski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-13 15:16   ` [PATCH v2 1/6] net: changed arp_hdr struct declaration Michal Jastrzebski
2015-02-13 15:16   ` [PATCH v2 2/6] bond: add link bonding mode 6 implementation Michal Jastrzebski
2015-02-13 15:16   ` [PATCH v2 3/6] bond: add debug info for mode 6 link bonding Michal Jastrzebski
2015-02-13 15:16   ` [PATCH v2 4/6] bond: add example application for link bonding mode 6 Michal Jastrzebski
2015-02-13 15:16   ` [PATCH v2 5/6] bond: modify TLB unit tests Michal Jastrzebski
2015-02-13 15:16   ` [PATCH v2 6/6] bond: add unit tests for link bonding mode 6 Michal Jastrzebski
2015-02-13 16:12   ` [PATCH v2 0/6] Link Bonding mode 6 support (ALB) Declan Doherty
     [not found]     ` <54DE2285.8000507-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-18 19:10       ` Thomas Monjalon
2015-02-19  9:18         ` Jastrzebski, MichalX K
     [not found]           ` <60ABE07DBB3A454EB7FAD707B4BB1582138EA984-kPTMFJFq+rHjxeytcECX8bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-19  9:39             ` Thomas Monjalon
2015-02-19 10:14               ` Jastrzebski, MichalX K
     [not found]                 ` <60ABE07DBB3A454EB7FAD707B4BB1582138EAA30-kPTMFJFq+rHjxeytcECX8bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-19 10:27                   ` Thomas Monjalon
2015-02-19 17:26   ` [PATCH v3 " Michal Jastrzebski
     [not found]     ` <1424366779-14256-1-git-send-email-michalx.k.jastrzebski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-19 17:26       ` [PATCH v3 1/6] net: changed arp_hdr struct declaration Michal Jastrzebski
     [not found]         ` <1424366779-14256-2-git-send-email-michalx.k.jastrzebski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-20 14:30           ` Thomas Monjalon [this message]
2015-02-20 14:54             ` Gajdzica, MaciejX T
     [not found]               ` <9CC680510C0AC140A846FED2EF7F962812E5F82E-kPTMFJFq+rFP9JyJpTNKArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-20 15:22                 ` Thomas Monjalon
2015-02-19 17:26       ` [PATCH v3 2/6] bond: add link bonding mode 6 implementation Michal Jastrzebski
2015-02-19 17:26       ` [PATCH v3 3/6] bond: add debug info for mode 6 link bonding Michal Jastrzebski
2015-02-19 17:26       ` [PATCH v3 4/6] bond: add example application for link bonding mode 6 Michal Jastrzebski
     [not found]         ` <1424366779-14256-5-git-send-email-michalx.k.jastrzebski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-20 14:42           ` Thomas Monjalon
2015-02-20 16:12             ` Jastrzebski, MichalX K
2015-02-19 17:26       ` [PATCH v3 5/6] bond: modify TLB unit tests Michal Jastrzebski
2015-02-19 17:26       ` [PATCH v3 6/6] bond: add unit tests for link bonding mode 6 Michal Jastrzebski
2015-02-20 16:09   ` [PATCH v4 0/6] Link Bonding mode 6 support (ALB) Michal Jastrzebski
     [not found]     ` <1424448563-8680-1-git-send-email-michalx.k.jastrzebski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-20 16:09       ` [PATCH v4 1/6] net: changed arp_hdr struct declaration Michal Jastrzebski
2015-02-20 16:09       ` [PATCH v4 2/6] bond: add link bonding mode 6 implementation Michal Jastrzebski
2015-02-20 16:09       ` [PATCH v4 3/6] bond: add debug info for mode 6 link bonding Michal Jastrzebski
2015-02-20 16:09       ` [PATCH v4 4/6] bond: add example application for link bonding mode 6 Michal Jastrzebski
2015-02-20 16:09       ` [PATCH v4 5/6] bond: modify TLB unit tests Michal Jastrzebski
2015-02-20 16:09       ` [PATCH v4 6/6] bond: add unit tests for link bonding mode 6 Michal Jastrzebski
2015-02-20 17:44       ` [PATCH v4 0/6] Link Bonding mode 6 support (ALB) Declan Doherty
     [not found]         ` <54E7728E.3090208-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-20 21:58           ` Thomas Monjalon
2015-03-04  3:53           ` Jiajia, SunX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1694402.UUemy3W7BY@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=michalx.k.jastrzebski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).