From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] bbdev: fix exported dynamic log type
Date: Tue, 06 Feb 2018 18:50:34 +0100
Message-ID: <1695986.x6khAz695a@xps>
References: <1517869651-145451-1-git-send-email-amr.mokhtar@intel.com>
 <1517923770-45640-1-git-send-email-amr.mokhtar@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, ferruh.yigit@intel.com
To: Amr Mokhtar <amr.mokhtar@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 3A5251B6D4
 for <dev@dpdk.org>; Tue,  6 Feb 2018 18:50:39 +0100 (CET)
In-Reply-To: <1517923770-45640-1-git-send-email-amr.mokhtar@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

06/02/2018 14:29, Amr Mokhtar:
> This patch fixes shared library compilation due to undefined
> reference to an exported variable 'bbdev_logtype'.
> 
> v2:
> * In this fix,
> * - The logtype has become static and owned individually by each
> *    component.
> * - Helper logging macros are removed from bbdev lib header files
> *    and replaced with macros defined by each driver at its ease.
> * - 'bbdev_logtype' removed from .map
> 
> v1:
> * This patch fixes shared library compilation due to undefined
> * reference to an exported variable 'bbdev_logtype'.
> * In this fix, the logtype is converted to static in the bbdev lib,
> * in bbdev null pmd and turbo sw pmd.
> 
> 
> Fixes: 4935e1e9f76e ("bbdev: introduce wireless base band device lib")
> Fixes: b8cfe2c9aed2 ("bb/turbo_sw: add software turbo driver")
> Fixes: 7dc2b1589440 ("bb/null: add null base band device driver")
> Cc: thomas@monjalon.net
> 
> Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>

Applied, thanks